Issues
Hello, thanks for this module, I've got it installed, and am working on tweaking some things for my purposes, but wanted to share the things I've run into so far.
1) When doing a guild refresh, all the wowcharsheet_set_constant variables are being resaved to empty. When a character is entered into the DB, it populates correctly, but not from the guild update.
To remedy this, I simply commented out lines 256-259 in wowcharsheet.update.inc.php
2) Having an ongoing issue with permissions. Roles with the correct permission 'can associate toon' are not able to do so. I haven't isolated what is causing this on my site yet, but I'm still researching.
3) Various stats are not being reported correctly. From a wowcharsheet toon, stats like Spell Crit, Hit, are not being saved correctly. Not difficult to fix, just an fyi.
4) Some users see a SQL error when visiting Guild Roster.
user warning: Column 'nid' in field list is ambiguous query: _wowcharsheet_displayguild_ajax_do_search /* User : _wowcharsheet_displayguild_ajax_do_search */ SELECT uid,nid,title,type FROM node INNER JOIN node_access na ON na.nid = n.nid WHERE (na.grant_view >= 1 AND ((na.gid = 0 AND na.realm = 'all') OR (na.gid = 2 AND na.realm = 'forum_access') OR (na.gid = 3 AND na.realm = 'forum_access'))) AND ( type='wow_toon') in /wowcharsheet/wowcharsheet.module on line 825.
This code appears to be doing a lookup for claimed toons, but I see nothing making use of the results, so for now I've just commented out. I am modifying this section to show the LastLogin time of any users that have a claimed toon, so our officers can tell who is keeping up on the site.
5) The Cron issue I was running into is related to db_query escaping the where clause string. I haven't looked to see how the updated version fixed it. To correct it, I just passed the Where directly into the db_query, instead of as a printf variable.
6) While I have not tried it recently, when I tried to associate/claim a toon via the admin interface, it blew up on me. I don't recall the error, just sharing an experience that I need to retest.
My biggest current issue is #2, which is what I'm trying to isolate. I am going to remove the modules completely, uninstall/remove DB tables, and try it again.
In relation to your forums here, This forum, and then the Categories are the only forums I have post permissions too. May want to fix that :)
-Paul
Forum Update
There's nothing like developing sites on the fly!
I installed the Advanced Forum and Flatten Comments Modules. It worked as intended and flattened the comments, but it also put them out of order. Oh well. Hopefully the forum will work more like a regular forum now.
Clain Toon
Ok,
I had some time to look at it. There was an SQL error in claim toon, that should be fixed. The text 'claim this toon' should appear under unclaimed toons (browse to /toon/[realm]/[tooname]).
Toons can also be added using Create Content -> WoW Toon, and assigned authored by to a particular user.
Mainly I use the Manage Guild Roster link to attach toons to users. I'll have a look and see if that's working properly.
If you are not using the Devel module, give that a shot. I't pretty useful for debugging.
With any luck I didn't add any more errors than I removed! updated module
Cron Issue with Latest Version :P
Getting this when Cron Runs when I have the update guild characters selected:
Fatal error: Cannot redeclare item_link() (previously declared in /home/paulcole/public_html/drp/modules/wowcharsheet/wowcharsheet-toon.tpl.php:12) in /home/paulcole/public_html/drp/modules/wowcharsheet/wowcharsheet-toon.tpl.php on line 36
This one I'm not sure where to look, as I don't understand how the whole cron hooks work yet.
Getting this when Cron Runs
Humm. Not sure why cron (which updates characters) calls the template file (for displaying toons). I'll have a look and see.
The only way I can get it to
The only way I can get it to work right, is to give the role "Administer Nodes" to the Role the users are a member of. This then made it so both the menu displayed, and the Form didn't give "Access Denied" when going to node/add/wow-toon
So that semi solved the problem, but I don't think its the "right" fix, but I can't find out ANYWHERE on what is preventing users from accessing the node/add/wow-toon area, when they can access node/add/wiki and the likes just fine.
No dice
I've been messing around with this for a few hours, and have had no luck figuring out whats causing the problem.
I've edited _perm and _menu, rebuilt menus, updated modules, and have had no luck getting this working yet.
I *THINK* there was a fatfinger in the theme template, cause it had a misspelling of the permission but I fixed it, but still am having issues.
I'm pretty fluent with PHP, so I'll keep digging, but if you have any ideas on howto make drupal show WHY an Access Denied message pops up, that would be helpful :)
Noted.
Yes, there is a seperate permission "can associate toon" that enables the menu item.
It then creates a wow_toon type node (of that character) and associates it with the user. So programmatically it requires "can create toon." I don't think that is the best implementation. Let me know if enabling "can create toon" permission works (and remove the menu item so they can not randomally create toons), works.
I'll have a look if it does not.
Permissions issue
Is not fixed.
Its better, in that at least users see the Claim Character Menu (Called Link Character on my site), but when a user clicks the link, which takes you to node/add/wow-toon it doesn't work. It gives a
Access denied
You are not authorized to access this page.
Being new to drupal still, I am not sure howto troulbeshoot this. I've got the "can associate toon" flag set, and even enabled it for anon users, and I still cant get a non-admin to be able to claim a character.
Does it need to have a permission to "Create wow_toon" node type? Thats the only thing I can think of, but I am lost otherwise. There are no permissions listed under node for the wow_toon content type.
So tooltip bug was my fault,
So tooltip bug was my fault, did an upgrade on the modules the wrong way.
copied old files back, disabled, uninstalled completely.
Installed new modules (including Lootz) and my permission issue is fixed, and the tooltips look hot :)
looking to see if there is still an issue with the Guild REfresh blowing away variables.
I like the lootz module, but I have a feeling making items cached on the webserver will be much harder with that going forward. But they look very nice.
Bug in Latest Release with tooltip
Latest tooltip has a bug:
1) Tooltip not opening up, but the correct image is being shown.
2) the URL when moused over is jacked up, I imagine causing the problem:
http://mysite.com/drp/WOWHEAD_BASE_URL/WOWHEAD_SEARCH_ID45273